Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: bagit created by Storage Service after reingest may have outdated tag manifest files #449

Closed
sevein opened this issue Jan 21, 2019 · 2 comments
Assignees
Labels
CVA Severity: high A high-priority situation where performance or other uses are significantly impacted or degraded. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone

Comments

@sevein
Copy link
Contributor

sevein commented Jan 21, 2019

Expected behaviour
SS shouldn't create invalid bags.

Current behaviour
After full reingest, Storage Service executes a number of steps in order to replace the original AIP with the new re-ingested AIP. In particular, as the payload of the bag has changed, SS uses python-bag to regenerate the manifests. When the original package is a BagIt v0.96, the library does not update optional tag manifests.

This is a problem when the package is transferred to the pipeline again because during the validation process we're using the Java version which verifies optional tag manifests. tagmanifest-md5.txt wasn't updated so the verification process fails and the transfer is rejected.

A potential solution is to update the BagIt package to v0.97.

Steps to reproduce

  1. Import really old Archivematica AIP (pre AM v1.x, see more in #24)
  2. Confirm that it uses BagIt v0.96
  3. Full re-ingest
  4. Download new re-ingested AIP and verify the tag manifest files.

Your environment (version of Archivematica, OS version, etc)
Tested using: bagit-python v1.5.4 and v1.7.0
AM qa/1.x 6de2fc11d11c2013a11b9a6864d9f23dc89f3681


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@sevein sevein changed the title Problem: bagit created by Storage Service after reingest may be invalid Problem: bagit created by Storage Service after reingest may have outdated tag manifest files Jan 22, 2019
@sevein
Copy link
Contributor Author

sevein commented Jan 22, 2019

This is being fixed in #24.

@sevein sevein added Status: in progress Issue that is currently being worked on. CVA Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. Severity: high A high-priority situation where performance or other uses are significantly impacted or degraded. and removed triage-release-1.10 labels Mar 10, 2019
@sevein sevein added this to the 1.10.0 milestone Mar 12, 2019
@sevein sevein self-assigned this Mar 12, 2019
@sevein sevein added Status: review The issue's code has been merged and is ready for testing/review. and removed Status: in progress Issue that is currently being worked on. labels May 10, 2019
@sevein sevein removed their assignment May 10, 2019
@evelynPM
Copy link

Tested by re-ingesting an AIP from 2012, then downloaded the re-ingested AIP and used bagger to verify. I also visually inspected the manifest-sha256 file. All looks good.

@evelynPM evelynPM removed the Status: review The issue's code has been merged and is ready for testing/review. label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVA Severity: high A high-priority situation where performance or other uses are significantly impacted or degraded. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

No branches or pull requests

2 participants