Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding getCrawlYear in ArchiveRecords, resolves #104 #105

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

ianmilligan1
Copy link
Member

GitHub issue(s):

What does this Pull Request do?

This pull request:

  • Adds getCrawlYear to accompany getCrawlMonth and getCrawlDate
  • No features removed
  • Has been tested on scripts

How should this be tested?

This is not fixing a bug but adding a new feature. Usage example can be seen in the #104 ticket, and will be added to documentation. I don't think it will have a real effect on code coverage, but we will see (getCrawlMonth is also not part of unit tests right now, I think).

Additional Notes:

Will test locally to see if this fits use case.
@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #105 into master will increase coverage by 0.12%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   67.55%   67.67%   +0.12%     
==========================================
  Files          38       38              
  Lines         752      758       +6     
  Branches      141      142       +1     
==========================================
+ Hits          508      513       +5     
  Misses        194      194              
- Partials       50       51       +1
Impacted Files Coverage Δ
...archivesunleashed/spark/archive/io/ArcRecord.scala 73.33% <100%> (+1.9%) ⬆️
...rchivesunleashed/spark/archive/io/WarcRecord.scala 100% <100%> (ø) ⬆️
...eashed/spark/archive/io/GenericArchiveRecord.scala 80% <75%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a539a1c...b57469f. Read the comment docs.

@ruebot ruebot merged commit 010fe24 into master Oct 26, 2017
@ruebot ruebot deleted the Issue-104 branch October 26, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants