-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encrypted casts support + allow using the trait on multiple models #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lcolumn into encrypted-casts
stancl
reviewed
Aug 14, 2023
stancl
reviewed
Oct 26, 2023
stancl
changed the title
Add encrypted casts support
Add encrypted casts support + allow using the trait on multiple models
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypted casts
This PR adds support for encrypted casts. Laravel's default encrypted casts (
'encrypted'
,'encrypted:array'
,'encrypted:collection'
,'encrypted:json'
,'encrypted:object'
) work out of the box, but the custom casts have to be specified inVirtualColumn::$customEncryptedCastables
.The problem with encrypted casts is that VirtualColumn uses
$model->setAttribute()
, and when using the encrypted casts, the password gets encrypted multiple times in the end. To deal with that, we check if the value is encrypted. If it is, use$model->attributes[$key] = $value
instead of$model->setAttribute($key, $value)
to bypass the encryption.Shared state issues
When multiple models extended a base class that used VirtualColumn, there were issues with the shared state. Booting the trait would add event listeners specific to the model the trait's used on to the static
$afterListeners
property. The problem is that this was happening with each used model, and in the end, the models initialized after the first one wouldn't handle the events properly. For example, creating an instance of model Bar after creating Foo would result in Bar getting encoded using the same custom columns as Foo because Foo got initialized first.In this PR, most of the static things in the VirtualColumn trait got changed to non-static, so that the state isn't shared across models.