Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro.md #53

Merged
merged 3 commits into from
Oct 17, 2021
Merged

Update intro.md #53

merged 3 commits into from
Oct 17, 2021

Conversation

afidegnum
Copy link
Contributor

I guess you were explaining the difference between a template and a page. There was a typo on ln: 19

I guess you were explaining the difference between a template and a page. There was a typo on ln: 19
@arctic-hen7
Copy link
Member

Great! Could you change this in the next/ folder of the docs too so we have consistency?

@arctic-hen7
Copy link
Member

@afidegnum, would you mind making that change?

@afidegnum
Copy link
Contributor Author

ok, noted, I will update it.

Hopefully that explains the difference between a template and a post
Hopefully that explains the difference between a template and a page (I guess you are stating the difference between a template and a page.)
@arctic-hen7
Copy link
Member

Okay, I think your new PR renders this obsolete, please let me know if I'm wrong.

@arctic-hen7
Copy link
Member

Okay actually this looks like the correct PR that has both changes, so I'm not sure what the other one is.

@arctic-hen7 arctic-hen7 reopened this Oct 16, 2021
Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to be merged.

@arctic-hen7 arctic-hen7 merged commit 1aff29c into framesurge:main Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants