Add support for pandoc #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hej @tpoisot, just tested your pull request, good job. Do you use an option like
|
|
You're right, I did have that! Should it be added to the theme? I'm not sure how it can interact with other packages. |
|
I'm okay with that. I guess at least some documentation would be nice for new users. Any thoughts @arcticicestudio ? |
|
Anyone for reviewing this? Pandoc support is currently the main factor preventing me from switching to this theme |
arcticicestudio
added a commit
that referenced
this pull request
May 28, 2021
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> GH-256
arcticicestudio
added a commit
that referenced
this pull request
May 28, 2021
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> Closes GH-256
arcticicestudio
requested changes
May 29, 2021
There was a problem hiding this comment.
Hi @tpoisot 👋, thanks for your contribution 👍
Thanks for your patience, the large amount of tasks for the Nord project are really time consuming and free time is kind of rare.
I've suggested some changes to make it more consistent with existing theme styles. Let me know what you think about it.
Configuration and resources used for testing:
let g:pandoc#syntax#conceal#cchar_overrides = {"atx": "〉"}
let g:nord_italic = 1
|
@arcticicestudio - will have a look, thanks for the feedback! |
crispgm
pushed a commit
to crispgm/nord-vim
that referenced
this pull request
Jun 10, 2021
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in nordthemeGH-149, nordthemeGH-207 and nordthemeGH-211 with LaTeX and Pandoc being used by the reporters. PR nordthemeGH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> Closes nordthemeGH-256
|
@tpoisot Let me know if you'd like to apply the suggestions so I can resolve the current merge conflicts. |
|
I would love to, hopefully I'll find the time next week |
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
|
I think the merge conflicts are gone! |
svengreb
approved these changes
Jul 11, 2021
arcticicestudio
approved these changes
Jul 11, 2021
crispgm
pushed a commit
to crispgm/nord-vim
that referenced
this pull request
Jul 14, 2021
Add support for `vim-pandoc/vim-pandoc-syntax`
To improve syntax highlighting for Pandoc [1], support for the
vim-pandoc/vim-pandoc-syntax [2] plugin has been implemented.
Most groups are linked to existing Markdown groups to ensure a
consistent style across languages and different plugins.
Configurations used for testing:
```vim
let g:pandoc#syntax#conceal#cchar_overrides = {"atx": "〉"}
let g:nord_italic = 1
```
Resources:
- `g:pandoc#syntax#conceal#cchar_overrides` docs [3]
- `s:cchars` definition [4]
- Markdown "Extended Syntax" Guide [5]
[1]: https://pandoc.org
[2]: https://github.com/vim-pandoc/vim-pandoc-syntax
[3]: https://github.com/vim-pandoc/vim-pandoc-syntax/blob/68d7249/doc/pandoc-syntax.txt#L45-L50
[4]: https://github.com/vim-pandoc/vim-pandoc-syntax/blob/5056e63/syntax/pandoc.vim#L37-L72
[5]: https://www.markdownguide.org/extended-syntax
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>
Closes nordthemeGH-220
arcticicestudio
pushed a commit
that referenced
this pull request
Sep 12, 2021
Add support for `vim-pandoc/vim-pandoc-syntax`
To improve syntax highlighting for Pandoc [1], support for the
vim-pandoc/vim-pandoc-syntax [2] plugin has been implemented.
Most groups are linked to existing Markdown groups to ensure a
consistent style across languages and different plugins.
Configurations used for testing:
```vim
let g:pandoc#syntax#conceal#cchar_overrides = {"atx": "〉"}
let g:nord_italic = 1
```
Resources:
- `g:pandoc#syntax#conceal#cchar_overrides` docs [3]
- `s:cchars` definition [4]
- Markdown "Extended Syntax" Guide [5]
[1]: https://pandoc.org
[2]: https://github.com/vim-pandoc/vim-pandoc-syntax
[3]: https://github.com/vim-pandoc/vim-pandoc-syntax/blob/68d7249/doc/pandoc-syntax.txt#L45-L50
[4]: https://github.com/vim-pandoc/vim-pandoc-syntax/blob/5056e63/syntax/pandoc.vim#L37-L72
[5]: https://www.markdownguide.org/extended-syntax
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>
Closes GH-220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
nord-vimdoes not have support for most syntax elements from thevim-pandoc-syntaxpackage (#207):I have added support for these groups - notably, this solves the issues with
Conceal(notably #211). This is the result with the additional syntax groups: