Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conceal highlighting group support #256

Closed
arcticicestudio opened this issue May 9, 2021 · 0 comments · Fixed by #261
Closed

Conceal highlighting group support #256

arcticicestudio opened this issue May 9, 2021 · 0 comments · Fixed by #261

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 9, 2021

The Conceal group is currently not supported which can result in rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet mathematical expressions that are often used in LaTeX or Pandoc documents. These characters are currently highlighted with the default background color which makes them kind of unreadable with the theme foreground color.
See :help conceal and :help concealcursor for more details about concealing in Vim.

To fix the problem, the Conceal group will be added with its background color set to NONE for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context.

The problem has been reported in #149, #207 and #211 with LaTeX and Pandoc being used by the reporters. PR #220 adds support for vim-pandoc/vim-pandoc-syntax specific highlighting groups and can be merged after adding basic support for Conceal.

@arcticicestudio arcticicestudio added this to the Next milestone May 9, 2021
@arcticicestudio arcticicestudio changed the title Support Conceal highlighting group Conceal highlighting group support May 9, 2021
arcticicestudio added a commit that referenced this issue May 28, 2021
The `Conceal` group was not supported which could have led to rendering
problems for (Unicode) characters that require special encoding like
the ones from the Greek alphabet [1] that are often used in LaTeX [3] or
Pandoc [4] documents. These characters were highlighted with the default
background color which makes them kind of unreadable with the theme
foreground color.
See `:help conceal` and `:help concealcursor` for more details about
concealing in Vim.

To fix the problem, the `Conceal` group has been added with its
background color set to `NONE` for GUI and terminal mode to either use
the terminal default background color or let loaded scripts apply custom
styles based on the current runtime context.

The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX
and Pandoc being used by the reporters. PR GH-220 adds support for
vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be
merged after adding basic support for `Conceal`.

[1]: https://en.wikipedia.org/wiki/Greek_alphabet
[2]: https://www.overleaf.com/learn/latex/mathematical_expressions
[3]: https://www.latex-project.org
[4]: https://pandoc.org
[5]: https://github.com/vim-pandoc/vim-pandoc-syntax

Co-authored-by: Sven Greb <development@svengreb.de>

GH-256
arcticicestudio added a commit that referenced this issue May 28, 2021
The `Conceal` group was not supported which could have led to rendering
problems for (Unicode) characters that require special encoding like
the ones from the Greek alphabet [1] that are often used in LaTeX [3] or
Pandoc [4] documents. These characters were highlighted with the default
background color which makes them kind of unreadable with the theme
foreground color.
See `:help conceal` and `:help concealcursor` for more details about
concealing in Vim.

To fix the problem, the `Conceal` group has been added with its
background color set to `NONE` for GUI and terminal mode to either use
the terminal default background color or let loaded scripts apply custom
styles based on the current runtime context.

The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX
and Pandoc being used by the reporters. PR GH-220 adds support for
vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be
merged after adding basic support for `Conceal`.

[1]: https://en.wikipedia.org/wiki/Greek_alphabet
[2]: https://www.overleaf.com/learn/latex/mathematical_expressions
[3]: https://www.latex-project.org
[4]: https://pandoc.org
[5]: https://github.com/vim-pandoc/vim-pandoc-syntax

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-256
crispgm pushed a commit to crispgm/nord-vim that referenced this issue Jun 10, 2021
The `Conceal` group was not supported which could have led to rendering
problems for (Unicode) characters that require special encoding like
the ones from the Greek alphabet [1] that are often used in LaTeX [3] or
Pandoc [4] documents. These characters were highlighted with the default
background color which makes them kind of unreadable with the theme
foreground color.
See `:help conceal` and `:help concealcursor` for more details about
concealing in Vim.

To fix the problem, the `Conceal` group has been added with its
background color set to `NONE` for GUI and terminal mode to either use
the terminal default background color or let loaded scripts apply custom
styles based on the current runtime context.

The problem has been reported in nordthemeGH-149, nordthemeGH-207 and nordthemeGH-211 with LaTeX
and Pandoc being used by the reporters. PR nordthemeGH-220 adds support for
vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be
merged after adding basic support for `Conceal`.

[1]: https://en.wikipedia.org/wiki/Greek_alphabet
[2]: https://www.overleaf.com/learn/latex/mathematical_expressions
[3]: https://www.latex-project.org
[4]: https://pandoc.org
[5]: https://github.com/vim-pandoc/vim-pandoc-syntax

Co-authored-by: Sven Greb <development@svengreb.de>

Closes nordthemeGH-256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants