Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customServerHandler - should not removed #4939

Closed
cwlim opened this issue Dec 14, 2022 · 1 comment
Closed

customServerHandler - should not removed #4939

cwlim opened this issue Dec 14, 2022 · 1 comment

Comments

@cwlim
Copy link

cwlim commented Dec 14, 2022

Is your feature request related to a problem? Please describe.

customServerHandler is removed in version 0.80.0. It was a great feature to enhance the server with Express middlewares to meet NFRs on logging and a custom healthcheck endpoint.

https://github.com/Urigo/graphql-mesh/blob/master/packages/cli/CHANGELOG.md#0800

Removing customServerHandler prevents us from upgrading to newer versions of Graphql-Mesh (>0.80.0).

Describe the solution you'd like
Add customServerHandler back.

Describe alternatives you've considered
Research into Envelop pluggins. It impacts multiple teams and projects.

Additional context

@ardatan
Copy link
Owner

ardatan commented Mar 29, 2023

customServerHandler was leading a lot of incompatibility issues when it is used with different server frameworks, Apollo Server etc. For example, Apollo Server doesn't fully support Envelop and its plugin system is not compatible with Mesh's.
We dropped it but this doesn't mean people cannot implement their own server with Mesh. You can still use artifacts with Express or any other server framework;
https://the-guild.dev/graphql/mesh/docs/getting-started/deploy-mesh-gateway#mesh-as-an-express-route

@ardatan ardatan closed this as completed Mar 29, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants