Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options/variables on the Note Counter #6

Open
Hans5958 opened this issue Sep 13, 2019 · 4 comments
Open

Add more options/variables on the Note Counter #6

Hans5958 opened this issue Sep 13, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Hans5958
Copy link
Collaborator

Hans5958 commented Sep 13, 2019

Some suggestions from the community:

  • Add thousands seperator options (comma, dot, etc.)
  • Add decimal point options (comma, dot, etc.)
  • Make additional zeros (Mr Blackmidi#5405)

(also suggested by jimo#5727 on the BMC server)

@Hans5958 Hans5958 added the enhancement New feature or request label Sep 13, 2019
@arduano
Copy link
Owner

arduano commented Jan 22, 2020

As far as I'm aware, I can only do dots for decimal and comma for thousands. I've added a checkbox that disables thousands separators. Additional zeroes would be quite difficult to implement in a customizable way, I'm not sure how to do it.

@Hans5958
Copy link
Collaborator Author

Hans5958 commented Mar 3, 2020

As far as I'm aware, I can only do dots for decimal and comma for thousands. I've added a checkbox that disables thousands separators. Additional zeroes would be quite difficult to implement in a customizable way, I'm not sure how to do it.

I think it is best to do it manually with code than by automatically using windows locales or something. I heard it is possible on C# based on this links:
https://docs.microsoft.com/en-us/dotnet/standard/base-types/standard-numeric-format-strings#NFormatString
https://docs.microsoft.com/en-us/dotnet/standard/base-types/how-to-pad-a-number-with-leading-zeros

....

I have two ways:

  1. Make a switch for it, perhaps do it in another tab because there's a lot.
  2. Add arguments on the variable container. Maybe variable:argument1,argument2 (nps:trailingzerocount) or variable(argument1,argument2) (nps(trailingzerocount)). I think regex could do that.

(Dropping old suggestions for the future.)

@Niccori250k
Copy link
Collaborator

Additional Zeroes are available from 2.1.0.
I think using other characters as thousand separator or decimal point is not necessary.
Do I have to try?

@Hans5958
Copy link
Collaborator Author

Additional Zeroes are available from 2.1.0.
I think using other characters as thousand separator or decimal point is not necessary.
Do I have to try?

Sure, if you had time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants