Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Inconsistent platform libraries API #66

Closed
MrPointer opened this issue Dec 29, 2018 · 0 comments
Closed

Inconsistent platform libraries API #66

MrPointer opened this issue Dec 29, 2018 · 0 comments
Assignees
Labels
bug Potential bug in code priority: normal Normal priority - Probably will be implemented some time soon

Comments

@MrPointer
Copy link
Member

MrPointer commented Dec 29, 2018

Based on the amount of related issues opened lately, and a general feedback from community - It seems that the current API of platform libraries isn't clear enough, and inconsistent with the API of other types of libraries.

The biggest problem is that the general library API is based on finding them, then linking them to a target, just as one would do in "ordinary" CMake.
However, since platform libraries are essential to Arduino development and their location is known once the entire platform is found - Logically, they don't seem to be needed to be found, thus requiring users only to link them to targets.
This, as it turns out, is not so "logical" afterwards, and should be addressed differently.

Edit: It appears that there's a serious lack of support for direct usage of platform libraries.
While these can be perfectly used by other libraries, such as 3rd party libs, users can't use them directly as part of their application now - It should be addressed immediately.

Platform libraries can be linked to cmake targets using the link_platform_library function.

@MrPointer MrPointer added feature New feature priority: normal Normal priority - Probably will be implemented some time soon labels Dec 29, 2018
@MrPointer MrPointer changed the title Inconsistent API for platform libraries Fix missing API for platform libraries Dec 30, 2018
@MrPointer MrPointer self-assigned this Dec 30, 2018
@MrPointer MrPointer changed the title Fix missing API for platform libraries Inconsistent platform libraries API Dec 30, 2018
@MrPointer MrPointer added bug Potential bug in code and removed feature New feature labels Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Potential bug in code priority: normal Normal priority - Probably will be implemented some time soon
Projects
None yet
Development

No branches or pull requests

1 participant