-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usb core fixes #3640
Usb core fixes #3640
Conversation
3946bd8
to
29276e0
Compare
@ArduinoBot build this please |
@ArduinoBot, build this please. |
Some quick comments:
|
Thx for the comments
|
|
The patch for descriptors > 255 is here if you want to give it a try 😉 |
Feel free to discuss it now. Not all MCUs have a 0x8000 ram position, so the u2 Series would be totally incompatible without that fix. And for my Bootloader I changed the address to RAMEND now. I dont want to start a discussion here about a new bootloader or not which keeps the PR from being merged. I want to make the PR the way that if you do want a new bootloader, you are able to change the key very easy. You could also think about adding HL2 as bootloader https://github.com/NicoHood/HoodLoader2/tree/fast-usbserial If you ship a new bootloader or not can be discussed later. We could make the definition only point at the 0x8000 (without the (uint16_t) thing) so you can use a global boards.txt definition to pass the new bootkey location (extra_flags). Then you can have a IDE submenu for choosing old vs new bootloader. I made it this way to be able to also use 8bit bootkeys since this saves some bytes on the u2 Series. But since its not so heavy I'd probably go for a definition of the position itself and if it should be backed up or not. Or maybe simply back it up if its unequal RAMEND so simplify it. (updating soon, so you can see what I mean). |
29276e0
to
60e64cf
Compare
Updated the commits, now you can add via board.txt:
Very simple to change the position now and to fix this issue. No additional variants file is even needed. |
Thanks so much! One thing I want to mention is that this is still incorrect: I'd now focus on the HID libraries. There is also stuff to improve. |
Backported a few fixes from https://github.com/NicoHood/HID
Replaces older
#3562