Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error in v4.0.4 #724

Closed
zfields opened this issue Sep 2, 2023 · 3 comments
Closed

Compile error in v4.0.4 #724

zfields opened this issue Sep 2, 2023 · 3 comments

Comments

@zfields
Copy link
Contributor

zfields commented Sep 2, 2023

~/.arduino15/packages/arduino/hardware/mbed_nano/4.0.4/cores/arduino/api/CanMsg.h:71:71: error: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'uint32_t {aka long unsigned int}' [-Werror=format=]
     len = snprintf(buf, sizeof(buf), "[%08X] (%d) : ", id, data_length);

I was going to offer a patch, but I cannot find the path.
https://github.com/arduino/ArduinoCore-mbed/tree/4.0.4/cores/arduino/api/CanMsg.h returns a 404.

@per1234
Copy link
Contributor

per1234 commented Sep 3, 2023

Hi @zfields. The files under the cores/arduino/api folder contain architecture independent code that can be shared by the cores of all Arduino boards platforms, so they are maintained in a dedicated repository, from which they are pulled while preparing the release packages of this platform that are distributed via Boards Manager:

https://github.com/arduino/ArduinoCore-API/blob/master/api/CanMsg.h

A proposed fix has already been submitted here: arduino/ArduinoCore-API#198. You are welcome to review that PR.

@zfields
Copy link
Contributor Author

zfields commented Sep 6, 2023

I see it was merged. What steps will need to transpire, before it becomes available in the CLI?

@facchinm
Copy link
Member

facchinm commented Sep 6, 2023

4.0.6 is in the oven, it will be published before the end of the week 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants