[BREAKING]: gRPC drop query field from LibrarySearchRequest (#2388)

arduino · Oct 25, 2023 · 6753a12 · 6753a12
1 parent b7ce9c8
commit 6753a12
Show file tree

Hide file tree

Showing 4 changed files with 255 additions and 270 deletions.
diff --git a/commands/lib/search.go b/commands/lib/search.go
@@ -40,10 +40,6 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchRequest) (*rpc.Lib
 func searchLibrary(req *rpc.LibrarySearchRequest, lm *librariesmanager.LibrariesManager) *rpc.LibrarySearchResponse {
 	res := []*rpc.SearchedLibrary{}
 	query := req.GetSearchArgs()
-	if query == "" {
-		query = req.GetQuery()
-	}
-
 	matcher := MatcherFromQueryString(query)
 
 	for _, lib := range lm.Index.Libraries {

diff --git a/docs/UPGRADING.md b/docs/UPGRADING.md
@@ -4,6 +4,10 @@ Here you can find a list of migration guides to handle breaking changes between
 
 ## 0.36.0
 
+### gRPC `cc.arduino.cli.commands.v1.LibrarySearchRequest` message has been changed.
+
+The `query` field has been removed, use `search_args` instead.
+
 ### CLI `core list` and `core search` changed JSON output.
 
 Below is an example of the response containing an object with all possible keys set.