Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING]: gRPC drop query field from LibrarySearchRequest #2388

Merged

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Dropping a deprecated field in favour of search_args

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini linked an issue Oct 25, 2023 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini force-pushed the 2386-remove-all-deprecated-field-from-the-grpc-api branch from f712799 to 6e14752 Compare October 25, 2023 09:00
@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba72833) 64.48% compared to head (6e14752) 64.50%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
+ Coverage   64.48%   64.50%   +0.02%     
==========================================
  Files         207      207              
  Lines       19593    19590       -3     
==========================================
+ Hits        12634    12637       +3     
+ Misses       5867     5863       -4     
+ Partials     1092     1090       -2     
Flag Coverage Δ
unit 64.50% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
commands/lib/search.go 96.25% <ø> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit 6753a12 into master Oct 25, 2023
200 checks passed
@alessio-perugini alessio-perugini deleted the 2386-remove-all-deprecated-field-from-the-grpc-api branch October 25, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all deprecated field from the gRPC api
2 participants