Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pluggable discovery board matching #1330

Merged
merged 4 commits into from
Jun 21, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 21, 2021

The implementation follows the pluggable discovery specification.

Now the board identification is done on myboard.upload_port.N.PROP definitions in boards.txt so, the old:

myboard.vid.0=0x1234
myboard.pid.0=0x4567

should be changed to:

myboard.upload_port.0.vid=0x1234
myboard.upload_port.0.pid=0x4567

Anyway, to keep backward compatibility all the existing non-pluggable platforms are automatically and transparently converted to the new format.

see arduino/tooling-rfcs#2

Added also a compatibility layer for existing platforms.
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes.

@cmaglie cmaglie merged commit b780f9c into arduino:master Jun 21, 2021
@cmaglie cmaglie deleted the pluggable-discovery-5 branch June 21, 2021 13:59
@silvanocerza silvanocerza mentioned this pull request Jul 9, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants