Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when loading boards #1354

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jul 9, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a crash when loading boards for certain platforms.

  • What is the current behavior?

Loading a platform with a board that declares a custom board option like so:

duemilanove.menu.cpu.atmega328=ATmega328P
duemilanove.menu.cpu.atmega168=ATmega168

but doesn't declare any custom board option name like menu.MENU_ID=Text crashes the CLI.

  • What is the new behavior?

Loading a platform with a board that declares a custom board option doesn't crash the CLI even if no option name is declared.

No.

  • Other information:

This bug was already fixed by #1326 but reintroduced with #1330.


See how to contribute

@silvanocerza silvanocerza requested a review from a team July 9, 2021 13:02
@silvanocerza silvanocerza self-assigned this Jul 9, 2021
@silvanocerza silvanocerza merged commit 65b2ea6 into master Jul 12, 2021
@silvanocerza silvanocerza deleted the scerza/fix-boards-loading branch July 12, 2021 08:39
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants