Improve contrast of cursor color in "Dark (Arduino)" theme

[kittaakos]

Describe the request

I think IDE2 should use a lighter color for the cursor color when the dark theme is active.

Describe the current behavior

With the Arduino dark theme, the cursor has almost the same color as the editor:

It's easier to notice the cursor position in the editor with the Theia (and VS Code) dark theme:

Arduino IDE version

5087ff0

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[pacav69]

@kittaakos i believe the cursor could be a block shape insted of a line this would make it easier to see and a perhaps colour of white to contrast the dark background.

[Tuczz]

Hello!

It's important to be clear where in the code you will write. The pure white would be better in my opinion.

Thanks,
Lucas

[seanspotatobusiness]

I am having the same problem with seeing the cursor. I keep typing in the wrong place because the cursor isn't where I thought it was.

[KurtE]

I second or third this, especially if you are going to remove Dark Theia theme
With Dark Theia, for example:
I can easily find it, especially when the editor is highlighting several similar words...

I have no clue:

But it is somewhere within this image

[Dracwula]

under 4K resolution this Dark theme cursor is hardly visible, even if enlarging font to 15pt its really difficult to distinguish cursor position while editing.

Arduino IDE v2.0.3

try to leave... get coffee...come back, you will not find it easily or toggling in between windows and refocus your eyes

[kittaakos]

Related #1721

[KurtE]

To me, this issue, is simply the current Dark Arduino Theme is not useable. The cursor is more or less invisible.

As is itrelated to #1721? Maybe only if that gave a user an easy way to fix this.

And if the DarkTheia theme is going away, that would mean you have no useable dark setup.

[aafloy]

I second @Dracwula on this; on my MacBook Pro M1 13" screen, I struggle to spot the cursor at all, even when moving it.

Adding that I do not use the default resolutions that macOS has available on this hardware, but the problem is present at lower resolutions (to a lower degree). At 1440 x 900 it looks like the cursor is to dark and blends too much with the other colors of the theme, which is augmented when increasing the resolution to 1680 x 1050 and 1920 x 1200.

Skjermopptak.2022-12-26.kl.21.51.51.mov

[KurtE]

Thanks,

Note: the cursor is now visible... To me just barely. So at least now the theme is usable, although, I will continue to use some other dark themes, that I downloaded and manually installed, like the Visual Studio Dark theme, as I personally prefer it.
And its cursor is a lot more visible.

[kittaakos]

This issue still needs to be resolved:

Version: 2.0.4-nightly-20230220
Date: 2023-02-20T03:11:24.086Z
CLI Version: 0.29.0

Copyright © 2023 Arduino SA

2.0.3 Arduino Dark theme:

2.0.4-nightly-20230220 Arduino Dark theme:

Expected behavior (also written in the issue description #1251 (comment)):

[per1234]

To reproduce

1. Start any version of Arduino IDE prior to 4f07515
2. Select File > Quit from the Arduino IDE menus.
3. Start any version of Arduino IDE from 4f07515 onward.
4. Select the "Dark (Arduino)" theme in the preferences if it is not already selected.
   🐛 The cursor still has the old low contrast #434f54 color instead of the new higher contrast #dae3e3 set by 4f07515
5. Select File > Quit from the Arduino IDE menus.
6. Rename or delete (:warning: cautiously) the following folder:
   • Windows:

     C:\Users\<user name>\AppData\Roaming\arduino-ide
     

   • Linux:

     ~/.config/arduino-ide
     

   • macOS:

     ~/Library/Application Support/arduino-ide
     

7. Start Arduino IDE.
   🙂 The cursor has the new higher contrast #dae3e3 color.

[kittaakos]

Thank you, Per!

Upstream: eclipse-theia/theia#11151