Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preference to limit thread count of the LS #2350

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: preference to limit thread count of the LS #2350

merged 1 commit into from
Feb 7, 2024

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 6, 2024 •
edited
Loading

Depends on arduino/vscode-arduino-tools#46 Done ✅

Motivation

Added a new preference (arduino.language.asyncWorkers) to control the number of async workers used by clangd.
Users can use fine tune the clangd thread count to overcome excessive CPU usage.

Change description

  • use 0.1.2 Arduino Tools VSIX,
  • use 0.35.2 CLI,
  • use 0.7.6 Arduino LS,
  • new preference to control the clangd thread count per sketch

Other information

Ref: arduino/arduino-language-server#177
Ref: arduino/vscode-arduino-tools#46

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server topic: CLI Related to Arduino CLI labels Feb 6, 2024
cmaglie
cmaglie approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The threads limit on the language server works as expected 👍

feat: preference to limit thread count of the LS
e983487 
Added a new preference (`arduino.language.asyncWorkers`) to control the
number of async workers used by `clangd`.
Users can fine tune the `clangd` thread count to overcome the excessive
CPU usage.

Use 0.1.2 Arduino Tools VSIX in IDE2.

Ref: arduino/arduino-language-server#177
Ref: arduino/vscode-arduino-tools#46

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos force-pushed the arduino/arduino-language-server#177 branch from 9dec544 to e983487 Compare February 7, 2024 10:30
@kittaakos kittaakos mentioned this pull request Feb 7, 2024
Merged
4 tasks
@kittaakos kittaakos merged commit d419a6c into main Feb 7, 2024
25 checks passed
@kittaakos kittaakos deleted the arduino/arduino-language-server#177 branch February 7, 2024 11:28
@per1234 per1234 added the type: enhancement Proposed improvement label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees
No one assigned
Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kittaakos @cmaglie @davegarthsimpson @per1234