Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in FQBN are not supported #75

Closed
3 tasks done
micheljung opened this issue Sep 29, 2022 · 3 comments
Closed
3 tasks done

Spaces in FQBN are not supported #75

micheljung opened this issue Sep 29, 2022 · 3 comments
Labels
type: imperfection Perceived defect in any part of project

Comments

@micheljung
Copy link

micheljung commented Sep 29, 2022

Describe the problem

Using an FQBN with spaces, like "Heltec-esp32:Heltec ESP32 Series Dev-boards:esp32" fails with Invalid FQBN: not an FQBN: Heltec-esp32:Heltec.

Escaping like "Heltec-esp32:Heltec\\ ESP32\\ Series\\ Dev-boards:esp32" fails with Invalid FQBN: not an FQBN: Heltec-esp32:Heltec\

To reproduce

jobs:
  compile:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        fqbn:
          - "Heltec-esp32:Heltec ESP32 Series Dev-boards:esp32"
    steps:
      - uses: arduino/compile-sketches@v1
        with:
          fqbn: ${{ matrix.fqbn }}
          platforms: |
            - name: "Heltec ESP32 Series Dev-boards:esp32"
              version: "0.0.6"
              source-url: https://resource.heltec.cn/download/package_heltec_esp32_index.json

Expected behavior

It should not fail.

'arduino/compile-sketches' version

v1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@micheljung micheljung added the type: imperfection Perceived defect in any part of project label Sep 29, 2022
@micheljung micheljung changed the title Spaces in FQBN Spaces in FQBN are not supported Sep 29, 2022
@micheljung
Copy link
Author

Ok I think it works like so:

        fqbn:
          - "\"Heltec-esp32:Heltec ESP32 Series Dev-boards:esp32\""

@micheljung
Copy link
Author

Not sure if this is related to spaces or not but it might be:

What to use as fqbn for https://resource.heltec.cn/download/package_heltec_esp32_index.json ? The doc says VENDOR:ARCHITECTURE but what corresponds to VENDOR?

If I try

        fqbn:
          - "\"Heltec-esp32:Heltec ESP32 Series Dev-boards:esp32\""
        with:
          fqbn: ${{ matrix.fqbn }}
          platforms: |
            - name: "Heltec-esp32:esp32"
              version: "0.0.6"
              source-url: https://resource.heltec.cn/download/package_heltec_esp32_index.json

I get:

  Error during build: Platform 'Heltec-esp32:Heltec ESP32 Series Dev-boards' not found: platform not installed
  Platform Heltec-esp32:Heltec ESP32 Series Dev-boards is not found in any known index
  Maybe you need to add a 3rd party URL?

and with

        fqbn:
          - "\"Heltec-esp32:Heltec ESP32 Series Dev-boards:esp32\""
        with:
          fqbn: ${{ matrix.fqbn }}
          platforms: |
            - name: "Heltec ESP32 Series Dev-boards:esp32"
              version: "0.0.6"
              source-url: https://resource.heltec.cn/download/package_heltec_esp32_index.json

I seem to get a step further:

Running command: /home/runner/bin/arduino-cli core install --additional-urls https://resource.heltec.cn/download/package_heltec_esp32_index.json Heltec ESP32 Series Dev-boards:esp32@0.0.6 
[...]
  Invalid argument passed: Found 0 platform for reference "Heltec ESP32 Series Dev-boards:esp32@0.0.6":

The command looks like it would need quotes but that seems to be a just display issue; otherwise the error message wouldn't contain the correct string.

@micheljung
Copy link
Author

micheljung commented Sep 29, 2022

From what I'm seeing, e. g. arduino:avr:uno from https://downloads.arduino.cc/packages/package_index.json, the FQBN rather seems to be PACKAGE_NAME:ARCHITECTURE:BOARD_NAME (whereas BOARD_NAME comes from board.txt in the referenced archive).

So my issue doesn't seem to be related to spaces but rather like #73, that it's not very well documented - or am I just not smart enough? :)

This seems to work now:

        fqbn:
          - "Heltec-esp32:esp32:wifi_lora_32_V2"

which makes sense, since it's the fully qualified board name ;)

and the platform is:

          platforms: |
            - name: "Heltec-esp32:esp32"
              version: "0.0.6"
              source-url: https://resource.heltec.cn/download/package_heltec_esp32_index.json

I guess I was just too tired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

1 participant