Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting failures have started appearing frequently in the past few weeks #94

Closed
3 tasks done
SpenceKonde opened this issue Jan 11, 2023 · 1 comment
Closed
3 tasks done
Assignees
Labels
conclusion: invalid Issue/PR not valid type: imperfection Perceived defect in any part of project

Comments

@SpenceKonde
Copy link

Describe the problem

It appears that github is being more aggressive about rate limiting, just happened in the past few weeks, but now to get a run to pass, I often have to rerun failed jobs several times for my cores.
The error output ends with this, which implies that there is a way to make an authenticated request. I see nothing in the documentation of compile-sketches that suggests that this is supported. It should be, because github seems to be trying to force people to authenticate actions (For quite a while I've occasionally had installation failures for the same reason, but those were few and far between and livewithable. It is no longer liverwithable. Every single attempt at running compile examples results in failures of this form, and it camoflages actual problems with the core.

The error ends in:
github.GithubException.RateLimitExceededException: 403 {"message": "API rate limit exceeded for 52.179.102.209. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", "documentation_url": "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}
Error: Process completed with exit code 1.

To reproduce

See the is example of a run that failed like this.

Expected behavior

I would like the rate limit to not be reached. Either throttle the routines, or provide a mechanism and document it to use the "authenticated requests" that the error message mentions

'arduino/compile-sketches' version

arduino/compile-sketches@main

Additional context

it seems that they're moving in the direction of severely curtailing anyone who doesn't authenticate, (i imagine because they're seeing abuse), but with little fluency in yaml (i'm much better at AVR assembly than this newfangled stuff - my brain only has a 16-bit address space; that's why I never liked the ATmega2560) and with difficulty understanding how the hell the whole scheme is supposed to work I was unsuccessful at getting another much simpler CI script that wanted a token (I don't know if that's the same thing) what it wanted.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@SpenceKonde SpenceKonde added the type: imperfection Perceived defect in any part of project label Jan 11, 2023
@per1234 per1234 self-assigned this Jan 13, 2023
@per1234
Copy link
Collaborator

per1234 commented Jan 13, 2023

Hi @SpenceKonde. It is supported and the relevant documentation is here:

https://github.com/arduino/compile-sketches#github-token

I have submitted a pull request to configure the workflow for authenticated GitHub API requests: SpenceKonde/megaTinyCore#895

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants