Solidify type names

aredridel · Mar 18, 2012 · a2ba703 · a2ba703
1 parent 2de1dd7
commit a2ba703
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/lib/Glip/GitBlob.php b/lib/Glip/GitBlob.php
@@ -46,4 +46,8 @@ protected function _serialize()
   {
   	return $this->data['data'];
   }
-}
+
+  public function getTypeName() {
+    return 'blob';
+  }
+}
diff --git a/lib/Glip/GitCommit.php b/lib/Glip/GitCommit.php
@@ -294,4 +294,8 @@ public function count()
   {
     return $this->tree->count();
   }
-}
+
+  public function getTypeName() {
+    return 'commit';
+  }
+}
diff --git a/lib/Glip/GitObject.php b/lib/Glip/GitObject.php
@@ -167,10 +167,7 @@ public function __get($name)
    * @return (string) the type name
    * @author Sjoerd de Jong
    **/
-  public function getTypeName()
-  {
-    return strtolower(substr(get_class($this),3));
-  }
+  abstract public function getTypeName();
 
   /**
    * Get the object's type number

diff --git a/lib/Glip/GitTree.php b/lib/Glip/GitTree.php
@@ -384,4 +384,8 @@ public function count()
   {
     return count($this->nodes);
   }
-}
+
+  public function getTypeName() {
+    return 'tree';
+  }
+}