Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS for Pgx_lwt_unix #110

Open
brendanlong opened this issue May 11, 2021 · 0 comments
Open

Support TLS for Pgx_lwt_unix #110

brendanlong opened this issue May 11, 2021 · 0 comments

Comments

@brendanlong
Copy link
Contributor

We added TLS support to Pgx_async using Conduit_async, but I couldn't find an STARTTLS upgrade interface for Conduit_lwt. We're open to PR's that implement this for Pgx_lwt_unix (and potentially Pgx_lwt_mirage).

We probably want to do this using Conduit_lwt or Tls_lwt.

See https://github.com/arenadotio/pgx/pull/108/files#diff-82209080f44391493efba0e6d9fab06647d561bdda34ea5099a23cd11fbe2ddc for an example of how we did this for Pgx_async. You should be able to implement this without needing to change any of the core Pgx code (although let us know if that's necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant