-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing skins under /v2/skins #78
Comments
That's a generic error message, and a That said, this appears to be a bug & I'll try to poke at it tomorrow. |
A |
It's not just 2984. Here's the full list. I would argue that these are not bad parameters -- each and every one of these is listed in the API. Maybe 500 is more appropriate. |
Really, who cares that much about the response codes. Its an error. The bug is with serializing the skin for the api (or listing it when it shouldn't be listed). This should be fixed. Changing the response code doesn't help anyone. Half of the comments on issues here in this repo or just about response codes, and not about the bug itself. /rant over |
Lol jeez |
I just removed all of those skin IDs from the whitelist -- I should drink some coffee. |
5898 is also returning |
2329 is back. |
Skin id 5898 still return status 400 :( |
Just re-blacklisted 2329 and 5898. Haven't had time to look into what exactly wrong with these, but given that it came back I really think it's some bad content somewhere. |
I'm gonna close this one out for now. smh. |
https://api.guildwars2.com/v2/skins/2984 yields an
ErrBadParam
while this id is listed under/v2/skins
.Also, the HTTP error should rather be a
204/No Content
than a400/Bad Request
- the latter sounds so passive aggressive... :PThe text was updated successfully, but these errors were encountered: