Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutterstop #10170

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix shutterstop #10170

merged 1 commit into from
Dec 18, 2020

Conversation

stefanbode
Copy link
Contributor

improved stop procedure to avoid overrun due to rounding issues between % and the real_position

Description:

Related issue (if applicable): fixes #10166

Checklist:

  • [ x] The pull request is done against the latest dev branch
  • [x ] Only relevant files were touched
  • [ x] Only one feature/fix was added per PR and the code change compiles without warnings
  • [ x] The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • [ x] The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • [x ] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

improved stop procedure to avoid overrun due to rounding issues between % and the real_position
@arendst arendst merged commit 50cb0bf into arendst:development Dec 18, 2020
@ascillato2 ascillato2 changed the title #10166 fixed Fix shutterstop Dec 18, 2020
@stefanbode stefanbode deleted the patch-8 branch September 5, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutters: The ShutterStop command triggers a reverse run of the shutter in certain situations
2 participants