Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of django-nvd3 #44

Closed
nordbit opened this issue Nov 23, 2014 · 5 comments
Closed

Future of django-nvd3 #44

nordbit opened this issue Nov 23, 2014 · 5 comments

Comments

@nordbit
Copy link

nordbit commented Nov 23, 2014

Any declarations?
Original nvd3 was abandoned.
One from community member working on fork here:
https://github.com/liquidpele/nvd3

Your project is a great but few bugs still exist, probably in nvd3 himself, but for now django-nvd3 is unusable for serious work becouse of few minor bug (like wrong displayed labels)

@areski
Copy link
Owner

areski commented Nov 23, 2014

django-nvd3 is a very basic wrapper on top of python-nvd3: https://github.com/areski/python-nvd3/
I trust that as we are pined to a well tested version of nvd3, we are far from saying "that django/python-nvd3 is unusable"

We will keep a close eyes to liquidpele works and certainly comply with it if his fork become a success.

@nordbit
Copy link
Author

nordbit commented Nov 24, 2014

Saying "unusable" I do not really mean unusable, it is a great piece of code. I'm only worring about future. For today all is great, but after 2-3 years non-maintained module (nvd3) can become troublemaker in any project. I can't find any sane python-wrapper for bare D3.js
Btw i have question:
For now template tag for displaying chart is called with definied width and height in pixels. By any chance can I call with responsive width (100% of container)? I can do dirty trick with javascript(jQuery) for scaling and fitting contetent. Its only way?

@areski
Copy link
Owner

areski commented Nov 24, 2014

That's the beauty of github, you can easily fork if the project is not maintained properly or even better you can send PR if you want to contribute to the project.

You can call the container with 100% to make it nicely responsive:

{% include_container final_chartcontainer 400 '100%' %}

To be noted, it's a bad practice to ask a non related question on a github issue.

@nordbit
Copy link
Author

nordbit commented Nov 25, 2014

So let's close this "issue". Thanks o lot for a sane response, giving me a lesson and great code.

@nordbit nordbit closed this as completed Nov 25, 2014
@areski
Copy link
Owner

areski commented Nov 25, 2014

Related to areski/python-nvd3#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants