Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer malfunctioning #276

Closed
robfairh opened this issue Jul 16, 2019 · 6 comments
Closed

Buffer malfunctioning #276

robfairh opened this issue Jul 16, 2019 · 6 comments

Comments

@robfairh
Copy link
Collaborator

robfairh commented Jul 16, 2019

I am trying to run this file:
https://github.com/robfairh/transition-scenarios/blob/experimental3/input/eg01-eg23/buffer%20after%20transition/eg01-eg23-flatpower-d3ploy-bufferB2000-ma.xml

and I get this message:

error.txt

Status: Cyclus run successful!
Output location: cyclus.sqlite
Simulation ID: 981e436e-091a-48a0-af5d-58988e36b645
Exception ignored in: <module 'threading' from '/home/roberto/anaconda3/lib/python3.6/threading.py'>
Traceback (most recent call last):
File "/home/roberto/anaconda3/lib/python3.6/threading.py", line 1289, in _shutdown
assert tlock.locked()
SystemError: <built-in method locked of _thread.lock object at 0x7f134a297a58> returned a result with an error set

If I delete the definition of the buffer it works.

It passes the integration tests for the buffer though...
@gwenchee any ideas?

@robfairh robfairh changed the title Buffer broken Buffer malfunctioning Jul 16, 2019
@gwenchee
Copy link
Collaborator

That's super weird, maybe u should investigate the history of the repo before each change implemented and see whether the buffer works there.

@gwenchee
Copy link
Collaborator

@robfairh

@robfairh
Copy link
Collaborator Author

robfairh commented Jul 16, 2019

Okay, I think the problem was that I was defining the buffer like this:

    <buffer_type>
    <item>
        <commod>sourceout</commod>
        <type>float</type>
    </item>
    </buffer_type> 

and I should do:

    <buffer_type>
    <item>
        <commod>sourceout</commod>
        <type>abs</type>
    </item>
    </buffer_type>

Is that correct? The user should now input 'rel' or 'abs' instead of 'perc' or 'float' right?
@gwenchee

@gwenchee
Copy link
Collaborator

yup that's been updated. Sorry i forgot to update this in the README. Could you help update that @robfairh

@robfairh
Copy link
Collaborator Author

The buffer works properly, the only issue is the readme then.
This issue can be closed when the readme reflects those changes.

@robfairh
Copy link
Collaborator Author

closed by #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants