Smart pointers, Registry changes, and registerAll migration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang format, and also new controllable advection
Ignore new build directory introduced in Dereks symlink moose PR
…isterAll function.
…e brace expression syntax.
|
Closing and resubmitting.....trying to change the PR target leads to a mess it seems... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of updating Zapdos (shannon-lab/zapdos#24) to the new registerAll static function, I noticed that Squirrel needed several of the same updates. This PR includes:
createAppcall inmain.C(Completely remove raw pointers from AppFactory idaholab/moose#10445)registerAllconsolidated registration function (Consolidate register idaholab/moose#12161)This tests successfully on my Mac (running Mojave and a reasonably new MOOSE environment - including clang 6.0.1). I also ran the
channel_gradient_test.iin theproblemsdirectory, and corrected a few deprecations there as well, and achieved a boundary layer-like result from it as a secondary test.