Consolidate register #12161
Consolidate register #12161
Conversation
rwcarlsen
force-pushed
the
consolidate-register
branch
2 times, most recently
from
957624f
to
d9b9715
Compare
|
Job Documentation on a8218e7 wanted to post the following: View the site here This comment will be updated on new commits. |
rwcarlsen
force-pushed
the
consolidate-register
branch
5 times, most recently
from
7a32753
to
40f7401
Compare
libmesh
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit 8516b0b93ad357ea9ec904d9021c18cf939e3bcb | |||
| Subproject commit bd111f4421ee3145f7dde6ac14aa82966cd28653 | |||
There was a problem hiding this comment.
Caution! This contains a submodule update
rwcarlsen
force-pushed
the
consolidate-register
branch
from
40f7401
to
e6e00f9
Compare
|
Job App tests on e6e00f9 : invalidated by @rwcarlsen |
1 similar comment
|
Job App tests on e6e00f9 : invalidated by @rwcarlsen |
rwcarlsen
force-pushed
the
consolidate-register
branch
from
e6e00f9
to
f5ee30b
Compare
libmesh
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit 8516b0b93ad357ea9ec904d9021c18cf939e3bcb | |||
| Subproject commit bd111f4421ee3145f7dde6ac14aa82966cd28653 | |||
There was a problem hiding this comment.
Caution! This contains a submodule update
rwcarlsen
force-pushed
the
consolidate-register
branch
2 times, most recently
from
c180404
to
c19bfa0
Compare
for Moose and for the test app. Deprecate the Moose::register[Objects/Actions/etc.] functions. Make ActionFactory and Syntax classes be idempotent w.r.t. registering stuff - so they correctly allow and don't incorrectly error for repeated/identical registrations. Modify MooseTestApp to only use/call registerAll and to not do anything else in its constructor. fully fixes idaholab#12106. ref idaholab#12136
- fix bugs and update some modules and unit test stuff - more Test and Unit app cleanup
…ld funcs - don't error on identical moose enum item additions. fix format test - make .C local funcs static to avoid ambiguity calling each other
- cleanup the fix for enum item errors - fix misc module all the way - fix bugs in dynamics registration with new regAll stuff
- update contact and fluid_properties modules - update functional_expansion_tools module - update heat_conduction module - functional_expansion_tools and heat_conduction forgotten mods - update level_set module - update navier_stokes module - update porous_flow module - update rdg module - update richards module - update solid_mechanics module - update stochastic_tools module - update xfem module
rwcarlsen
force-pushed
the
consolidate-register
branch
from
c19bfa0
to
a8218e7
Compare
| auto key = std::make_pair(name, task); | ||
| if (_current_objs.count(key) > 0) | ||
| return; | ||
| _current_objs.insert(key); |
There was a problem hiding this comment.
For future reference we have a moose_try_emplace() method (C++17 wrapper) which is more efficient (and a single line) for this type of thing.
A few straggler changes missed by idaholab#12161
|
Looks like this broke both our static build targets: |
A few straggler changes missed by idaholab#12161
| { | ||
| FluidPropertiesApp::registerObjects(factory); | ||
| registerSyntaxTask( | ||
| "AddFluidPropertiesAction", "Modules/FluidProperties/*", "add_fluid_properties"); |
There was a problem hiding this comment.
RELAP-7 and pronghorn register this syntax under FluidProperties/*, i.e. without the Modules prefix. The registerAll approach is nice, but we would need a way how to achieve the custom syntax path. Otherwise when we start using it it will break all our input files.
Originally, we would skip the syntax registration and would have our own implementation that would do the right thing. We would be fine with the registerAll approach as long as we could tell (may be upfront), that there will be some remapping going on. Or, any other simple solution...
There was a problem hiding this comment.
Calling:
syntax.replaceActionSyntax(AddFluidPropertiesAction,
"FluidProperties/*",
"add_fluid_properties",
__FILE__,
__LINE__);after the registerAll call should do the trick.
There was a problem hiding this comment.
Cool! I will test it in RELAP. Thanks!
There was a problem hiding this comment.
This worked. Just a small correction, the first parameter for replaceActionSyntax is std::string, so it should be "AddFluidPropertiesAction" - in case somebody finds this in future.
|
@rwcarlsen @permcody Is there going to be an email announcement or blog post about this? For those of us with non-registered apps, these types of changes can be tedious to fix if they accumulate. |
|
It'll at least get mentioned in the next mooseletter. Over the next several weeks, we'll work on updating apps that we can at INL. But there is no API breakage here - just deprecation. |
Fixes problems introduced by some doof in idaholab#12161. This was causing one test in rattlesnake to exodiff for distributed mesh runs on linux.
Fixes problems introduced by some doof in idaholab#12161. This was causing one test in rattlesnake to exodiff for distributed mesh runs on linux.
Consolidate the registerObjects, registerExecFlags, and associateSyntax static functions used to load up stuff for apps into a new, single static registerAll function. all registration stuff goes in it - including conditional test-object registration and registration of app/module dependency objects. This is made possible by modifications that make the registration process mostly idempotent - so the diamond problem of inter-app dependencies doesn't cause duplicate registration errors and such. Dynamic loading has also been updated to use this new registerAll func (i.e. extern C and dlopen stuff). This enables the full vision described in #12106.
The old register[Objects/ExecFlags] and associateSyntax functions in moose and modules have been deprecated. Apps should be updated to do all their stuff inside registerAll - this should simplify code a lot - and they no longer need to register stuff for their transitive dependencies - only their direct dependencies. The old functions will not be able to be removed, however, until all depending apps have been updated to use/call registerAll.