global object registry to simplify Moose.C #10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwcarlsen
force-pushed
the
obj-registry
branch
3 times, most recently
from
672ae97
to
a5851ac
Compare
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 7, 2018
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 8, 2018
|
Job Precheck on b9cb2be : invalidated by @rwcarlsen |
also remove unique_id stuff from ActionFactory
and update special case registrations
Also fix moose docs tests
|
FYI, Robert requested that we turn off the clang format check for this PR due to the "update tutorial" b21d151 commit having troubles with clang format. Any commits after that will not be guaranteed to be clang format clean. |
|
There is quite a bit of work to do in examples. I'm not sure we want to
hold up this PR for it. I'll keep working on it, but in the mean time
let's see if we can get this in without it. Also - that will leave us with
fewer changes not being checked by clang-format.
…On Thu, Mar 8, 2018 at 3:28 PM, brianmoose ***@***.***> wrote:
FYI, Robert requested that we turn off the clang format check for this PR
due to the "update tutorial" b21d151
<b21d151>
commit having troubles with clang format.
Any commits after that will not be guaranteed to be clang format clean.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10952 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABSeSiC_oEO40byabhf-hvZjVSIaWsowks5tcbB9gaJpZM4SdYXN>
.
|
permcody
approved these changes
Mar 9, 2018
|
|
||
| using paramsPtr = InputParameters (*)(); | ||
| using buildPtr = std::shared_ptr<MooseObject> (*)(const InputParameters & parameters); | ||
| using buildActionPtr = std::shared_ptr<Action> (*)(const InputParameters & parameters); |
| ent->addChild(new hit::Field("type", hit::Field::Kind::String, "action")); | ||
| ent->addChild(new hit::Field("task", hit::Field::Kind::String, act._name)); | ||
| ent->addChild(new hit::Field("class", hit::Field::Kind::String, act._classname)); | ||
| ent->addChild(new hit::Field("file", hit::Field::Kind::String, act._file)); |
There was a problem hiding this comment.
Lots of new raw allocations... I'm going to turn on the Valgrind target.
There was a problem hiding this comment.
BTW - I do realize that these are normally cleaned up in the tree destruction. I just know better than to assume that it always works when something changes.
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
follow up to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
Follow on to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
follow up to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
Follow on to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
follow up to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 9, 2018
follow up to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 14, 2018
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 14, 2018
follow up to idaholab#10952
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
Mar 14, 2018
This was referenced Mar 19, 2019
rwcarlsen
added a commit
to rwcarlsen/moose
that referenced
this pull request
May 7, 2019
The typo caused the generated static var for the macro to not be unique resulting in name clashes if more than one call exists in the same file. ref idaholab#10952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a global object registry and new object registration macros that use it. Objects are now registered in their own .C files like this:
instead of in a central location (e.g. Moose.C). I modified the [Foo]App::registerObjects functions to just pull registrations from the global registry. This preserves backward compatibility and allows us to easily migrate to the new registration macros. This has several benefits:
I wanted to get feedback/thoughts before I work to polish this up, add docs, etc. Does this seem like an okay approach?