Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionalize and document create_cyclus_input.py #162

Open
nsryan2 opened this issue Feb 23, 2024 · 1 comment
Open

Functionalize and document create_cyclus_input.py #162

nsryan2 opened this issue Feb 23, 2024 · 1 comment

Comments

@nsryan2
Copy link
Member

nsryan2 commented Feb 23, 2024

Currently, scripts/create_cyclus_input.py is unlike the other scripts in that it's actually like a script. This issue is mostly concerned with finding a way to document it (with examples where possible). If it can be turned into a series of functions like the other scripts, that would be a great addition.

This issue can be closed when there is a way to document scripts/create_cyclus_input.py with an example.

@RhysMacMillan
Copy link
Contributor

One spot I couldn't close in a PR regarding start year assumptions was in this script. It is assumed that start_year = 1965 as a global variable, along with some other global variables in the beginning. I thought about having a user input for the start year with a default of 1965 to satisfy current tests, but I decided to mention it here and not change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants