Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): process owner as part of dataset id #870

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

frascuchon
Copy link
Member

Closes #736

@frascuchon frascuchon requested a review from leiyre January 3, 2022 16:40
@leiyre leiyre requested review from leiyre and removed request for leiyre January 7, 2022 08:58
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #870 (99d058b) into master (d6a32dc) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 99d058b differs from pull request most recent head 01ec81d. Consider uploading reports for the commit 01ec81d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   95.48%   95.50%   +0.01%     
==========================================
  Files         109      109              
  Lines        4190     4202      +12     
==========================================
+ Hits         4001     4013      +12     
  Misses        189      189              
Flag Coverage Δ
pytest 95.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubrix/server/tasks/token_classification/metrics.py 99.41% <0.00%> (ø)
src/rubrix/metrics/token_classification/metrics.py 97.26% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a32dc...01ec81d. Read the comment docs.

@frascuchon frascuchon force-pushed the feat/process-owner-as-part-of-dataset-id branch from 99d058b to 01ec81d Compare January 7, 2022 14:35
@frascuchon frascuchon merged commit e3ee89e into master Jan 7, 2022
@frascuchon frascuchon deleted the feat/process-owner-as-part-of-dataset-id branch January 7, 2022 14:39
dvsrepo added a commit that referenced this pull request Jan 11, 2022
* 'master' of https://github.com/recognai/rubrix:
  feat(rules): compute total & ann. coverage before label selection (#916)
  fix(rules): compute annotated coverage when no label properly (#915)
  Tutorial: Human-in-the-loop weak supervision with skweak (#869)
  UI: include affected #records to overall coverage/ann. coverage metrics (#914)
  fix lint build (#913)
  UI: manage precision and rules without annotation coverage (#909)
  fix(#876): process 400 response detail properly (#889)
  feat(rules): allow compute partial query rule metrics (#907)
  fix(security): providing default workspace should pass check (#911)
  UI: reset filters from define rules view (#908)
  UI: Show number of created rules in rules management view (#910)
  UI: drop access to rule name field (#904)
  fix(rules): prevent lost rules with dataset updates (#892)
  fix(datasets): process owner as part of dataset id (#870)
  (UI) Rules summary metrics format (#888)
  UI: Improve code snippet for empty workspace (#886)
  fix(UI): Remove case sensitive when filtering labels (#882)
frascuchon added a commit that referenced this pull request Jan 11, 2022
* using owner as part of dataset id

* update dataset id references

* lint fix

* add ID to rule

Co-authored-by: LeireA <leire@recogn.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datasets] Datasets with same name in different workspaces are not shown in list
2 participants