Fix: kustomize write target starts failing after indeterminate period at time #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmavis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 65.86% 65.97% +0.11%
==========================================
Files 22 22
Lines 2045 2037 -8
==========================================
- Hits 1347 1344 -3
+ Misses 569 567 -2
+ Partials 129 126 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov>
ks-yim
pushed a commit
to ks-yim/argocd-image-updater
that referenced
this pull request
Jul 9, 2023
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: KS. Yim <ks.yim@linecorp.com>
jwhy89
pushed a commit
to jwhy89/argocd-image-updater
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: Jarvis Yang <jarvis.yang@recurohealth.com>
xescab
pushed a commit
to xescab/argocd-image-updater
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: Francesc Arbona <francesc.arbona@global.ntt>
dlactin
pushed a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes at least one of the causes of the image kustomize write back with git failing as documented in this issue: #240
Our Argo CD Image Updater deployment started having the same issue after switching to use Kustomize from Helm. After troubleshooting the issue with our setup, the process chdir that is happening in the write kustomization func didn't always chdir back to the original dir. Then subsequent
os.Getwd()calls would fail withgetwd: no such file or directorybecause the process working directory was still set to a previous temp dir that no longer exists. After reviewing the implementation details and testing, the chdir code doesn't appear to be needed anyway so it has been removed in the PR fixing the issue.Note:
make test,make test-raceandmake linttargets are all still passing after the changes.Also during testing, I noticed that zombie git processes are building up in the running container after each periodic image updater run. The Argo CD project had a similar issue: argoproj/argo-cd#3611. I will be opening another PR with a similar fix as well