Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Webhook URL ends with suffix / #70

Closed
jeanlucmongrain opened this issue Apr 6, 2020 · 1 comment · Fixed by #85
Closed

Webhook URL ends with suffix / #70

jeanlucmongrain opened this issue Apr 6, 2020 · 1 comment · Fixed by #85
Assignees
Labels
bug Something isn't working

Comments

@jeanlucmongrain
Copy link
Contributor

My webhook can't ends with /

time="2020-04-06T11:01:41Z" level=error msg="Failed to notify recipient webhook:slack defined in app argocd/xxx: request to https://example.com/hooks/yyy/ has failed with error code 405 : " app=argocd/xxx

that logic here

force this behavior.

  notifiers.yaml: |
    webhook:
      - name: slack
        url: https://example.com/hooks/yyy
        headers:
          - name: Content-Type
            value: application/json

and

  config.yaml: |
    triggers:
      - name: on-sync-failed
        enabled: true
        template: xxx-app-sync-failed # issue 69
    subscriptions:
      - recipients:
          - webhook:slack
        triggers:
          - on-sync-failed
    templates:
      - name: xxx-app-sync-failed
        webhook:
          slack:
            method: POST
            body: |
              {
                "text": "!!!!",
                "channel": "cd"
              }

don't work. Users must

  notifiers.yaml: |
    webhook:
      - name: slack
        url: https://example.com/hooks
        headers:
          - name: Content-Type
            value: application/json

and

    templates:
      - name: xxx-app-sync-failed
        webhook:
          slack:
            method: POST
            path: yyy
            body: |
              {
                "text": "!!!!",
                "channel": "cd"
              }

but that leak the API key yyy to be in the ConfigMap instead of the Secret

@alexmt alexmt added the bug Something isn't working label Apr 14, 2020
@alexmt alexmt self-assigned this May 6, 2020
@alexmt
Copy link
Collaborator

alexmt commented May 6, 2020

working on it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants