fix: don't append slash to webhook url (argoproj-labs#70)

notifiers/webhook.go

@@ -71,7 +71,10 @@ func (w webhookNotifier) Send(notification Notification, recipient string) error
 			urlPath = webhookNotification.Path
 		}
 	}
-	url := strings.TrimRight(webhookSettings.URL, "/") + "/" + strings.TrimLeft(urlPath, "/")
+	url := webhookSettings.URL
+	if urlPath != "" {
+		url = strings.TrimRight(webhookSettings.URL, "/") + "/" + strings.TrimLeft(urlPath, "/")
+	}
 	req, err := http.NewRequest(method, url, bytes.NewBufferString(body))
 	if err != nil {
 		return err

notifiers/webook_test.go

@@ -1,6 +1,7 @@
 package notifiers
 
 import (
+	"fmt"
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
@@ -45,3 +46,32 @@ func TestWebhook_FailedToSendNotConfigured(t *testing.T) {
 	assert.Error(t, err)
 	assert.Contains(t, err.Error(), "not configured")
 }
+
+func TestWebhook_SubPath(t *testing.T) {
+	var receivedPath string
+	server := httptest.NewServer(http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
+		receivedPath = request.URL.Path
+	}))
+	defer server.Close()
+
+	notifier := NewWebhookNotifier(WebhookOptions{{
+		Name: "test",
+		URL:  fmt.Sprintf("%s/subpath1", server.URL),
+	}})
+
+	err := notifier.Send(Notification{
+		Webhook: map[string]WebhookNotification{
+			"test": {Body: "hello world", Method: http.MethodPost},
+		},
+	}, "test")
+	assert.NoError(t, err)
+	assert.Equal(t, "/subpath1", receivedPath)
+
+	err = notifier.Send(Notification{
+		Webhook: map[string]WebhookNotification{
+			"test": {Body: "hello world", Method: http.MethodPost, Path: "/subpath2"},
+		},
+	}, "test")
+	assert.NoError(t, err)
+	assert.Equal(t, "/subpath1/subpath2", receivedPath)
+}