Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Add go test GitHub action to catch unit test regressions #83

Closed
jgwest opened this issue Dec 17, 2020 · 3 comments
Closed

Add go test GitHub action to catch unit test regressions #83

jgwest opened this issue Dec 17, 2020 · 3 comments

Comments

@jgwest
Copy link
Member

jgwest commented Dec 17, 2020

The Argo CD project uses GitHub actions that run go test (on non-E2E tests) for every PR commit. It would be great to include this here as well, to catch unit test regressions before they make it to master.

This should only run non-E2E tests, as E2E-tests are already covered in a separate GitHub Action in #66
@jgwest
Copy link
Member Author

jgwest commented Dec 17, 2020

I'm currently handling this on PR #64.

xianlubird pushed a commit that referenced this issue Jan 7, 2021
@jgwest
Add build and test GH action, fix TestGetApps race condition (#83) (#64)
1e1b453 
* Add build and test GH action, fix TestGetApps race condition

* Add build and test GH action, fix TestGetApps race condition
@OmerKahani
Copy link
Contributor

I think this can be closed #64 is merged

@jgwest
Copy link
Member Author

jgwest commented Jan 8, 2021

@OmerKahani 👍

@jgwest jgwest closed this as completed Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgwest @OmerKahani