Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Implement E2E test framework for testing ApplicationSet against live Kubernetes/Argo CD instance (#65) #66

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Nov 30, 2020

See parent issue for details: #65

To run locally:

@amitkrout
Copy link

@jgwest Can you please share the steps for how to verify it, thanks.

@jgwest jgwest changed the title Implement E2E test framework for testing ApplicationSets against live Kubernetes/Argo CD instance (#65) Implement E2E test framework for testing ApplicationSet against live Kubernetes/Argo CD instance (#65) Dec 9, 2020
@jgwest
Copy link
Member Author

jgwest commented Dec 9, 2020

@amitkrout Good thinking, I have documented how to do that as a new markdown file in the PR, you can see it here: https://github.com/jgwest/applicationset/blob/test-e2e/docs/E2E-Tests.md

Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is significant amount of copied codes from argocd test/e2e. Is there a way to shared these codes?

@jgwest
Copy link
Member Author

jgwest commented Jan 4, 2021

@wtam2018 Only <200 lines of code is shared (part of fixture.go, errors.go, cmd.go), I don't think its worthwhile to share them at this time.

@jgwest jgwest merged commit 571b30a into argoproj:master Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants