Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Add build and test GH action, fix TestGetApps race condition (#83) #64

Merged
merged 2 commits into from Jan 7, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Nov 24, 2020

This PR:

  • Adds a GitHub action to the workflow that runs the build (both docker and standalone), and then runs go test (the job/steps are based on Argo CD's)
  • Fixes the TestGetApps test, which was intermittently failing due to string ordering

Failing test:

2020/11/24 12:08:52 proto: tag has too few fields: "-"
--- FAIL: TestGetApps (0.00s)
    --- FAIL: TestGetApps/Happy_Flow (0.00s)
        repo_service_test.go:156: 
            	Error Trace:	repo_service_test.go:156
            	Error:      	Not equal: 
            	            	expected: []string{"app2", "app1"}
            	            	actual  : []string{"app1", "app2"}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,4 +1,4 @@
            	            	 ([]string) (len=2) {
            	            	- (string) (len=4) "app2",
            	            	- (string) (len=4) "app1"
            	            	+ (string) (len=4) "app1",
            	            	+ (string) (len=4) "app2"
            	            	 }
            	Test:       	TestGetApps/Happy_Flow
FAIL

@jgwest jgwest changed the title Add build and test GH action, fix TestGetApps race condition Add build and test GH action, fix TestGetApps race condition (#83) Dec 17, 2020
@jgwest
Copy link
Member Author

jgwest commented Jan 6, 2021

Review comments addressed and PR rebased.

@wtam2018
Copy link
Collaborator

wtam2018 commented Jan 7, 2021

/LGTM

@xianlubird xianlubird merged commit 1e1b453 into argoproj:master Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants