fix: Validate chat button url only when chatUrl is set (#12655) (#12749)

* Validate chat button url only when chatUrl is set Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Add Info Support to argocd USERS.md Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
argoproj · Mar 7, 2023 · 6953b43 · 6953b43
1 parent 0f500a5
commit 6953b43
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/USERS.md b/USERS.md
@@ -112,6 +112,7 @@ Currently, the following organizations are **officially** using Argo CD:
 1. [imaware](https://imaware.health)
 1. [Indeed](https://indeed.com)
 1. [Index Exchange](https://www.indexexchange.com/)
+1. [Info Support](https://www.infosupport.com/)
 1. [InsideBoard](https://www.insideboard.com)
 1. [Intuit](https://www.intuit.com/)
 1. [Joblift](https://joblift.com/)

diff --git a/ui/src/app/ui-banner/ui-banner.tsx b/ui/src/app/ui-banner/ui-banner.tsx
@@ -69,11 +69,13 @@ export const Banner = (props: React.Props<any>) => {
                         chatBottomPosition = 85;
                     }
                 }
-                try {
-                    const externalLink = new ExternalLink(chatUrl);
-                    chatUrl = externalLink.ref;
-                } catch (InvalidExternalLinkError) {
-                    chatUrl = 'invalid-url';
+                if (chatUrl) {
+                    try {
+                        const externalLink = new ExternalLink(chatUrl);
+                        chatUrl = externalLink.ref;
+                    } catch (InvalidExternalLinkError) {
+                        chatUrl = 'invalid-url';
+                    }
                 }
                 return (
                     <React.Fragment>