Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not configured chat url results in chat button shown #12655

Closed
woehrl01 opened this issue Feb 28, 2023 · 5 comments · Fixed by #12749
Closed

Not configured chat url results in chat button shown #12655

woehrl01 opened this issue Feb 28, 2023 · 5 comments · Fixed by #12749

Comments

@woehrl01
Copy link
Contributor

@saumeya @crenshaw-dev This change introduced in #10417, now results in showing the chat button even though there is no url at all configured.

This is because the chat url is explicitly set to an invalid url, if it can't parse.
@saumeya saumeya self-assigned this Feb 28, 2023
@saumeya
Copy link
Contributor

saumeya commented Feb 28, 2023 •
edited

Thanks for reporting @woehrl01 , I will take a look and fix it

@jmeridth jmeridth mentioned this issue Feb 28, 2023
Merged
6 tasks
@crenshaw-dev crenshaw-dev mentioned this issue Mar 2, 2023
Closed
3 tasks
@KyleSanderson
Copy link

Any update on this? I'm still being asked to CHAT NOW!

@svonliebenstein
Copy link

Yeah, it would be great if a little bug fix was created for this.

In our scenario we deploy the argocd-cm without even specifying the 'help.chatUrl' key. Since 2.6.3 the chat button is showing up.
@saumeya are you aware of this behavior?

A not set chat url should never cause the button to show up. I think the URL validation and error reporting should only show up if the key is filled with anything other then null or "".

@rouke-broersma rouke-broersma mentioned this issue Mar 7, 2023
Merged
10 tasks
@saumeya saumeya removed their assignment Mar 7, 2023
crenshaw-dev pushed a commit that referenced this issue Mar 7, 2023
@rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749)
6953b43 
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Mar 7, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Mar 7, 2023
@rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749)
9b923db 
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Mar 7, 2023
@rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749)
834bc12 
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
This was referenced Mar 7, 2023
Merged
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Mar 7, 2023
@rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749)
f555d5c 
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this issue Mar 7, 2023
@gcp-cherry-pick-bot @rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749…
e81ddb0 
…) (#12757)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this issue Mar 7, 2023
@gcp-cherry-pick-bot @rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749…
471e386 
…) (#12758)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this issue Mar 7, 2023
@gcp-cherry-pick-bot @rouke-broersma
fix: Validate chat button url only when chatUrl is set (#12655) (#12749…
8a7d291 
…) (#12759)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
@KyleSanderson
Copy link

I can happily confirm I am no longer being asked to CHAT NOW!

@crenshaw-dev
Copy link
Collaborator

Argo CD has been trying to reach you about your car's extended warranty...

yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@rouke-broersma
fix: Validate chat button url only when chatUrl is set (argoproj#12655)…
4589f90 
… (argoproj#12749)

* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Validate chat button url only when chatUrl is set rouke-broersma/argo-cd
5 participants
@crenshaw-dev @KyleSanderson @woehrl01 @saumeya @svonliebenstein