fix: helm set parameter to allow passing list parameters (#15978) (#1…

…5994) Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
argoproj · Oct 16, 2023 · a9c87d2 · a9c87d2
1 parent 0a40430
commit a9c87d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/util/helm/cmd.go b/util/helm/cmd.go
@@ -271,6 +271,10 @@ var (
 )
 
 func cleanSetParameters(val string) string {
+	// `{}` equal helm list parameters format, so don't escape `,`.
+	if strings.HasPrefix(val, `{`) && strings.HasSuffix(val, `}`) {
+		return val
+	}
 	return re.ReplaceAllString(val, `$1\,`)
 }
 

diff --git a/util/helm/helm_test.go b/util/helm/helm_test.go
@@ -165,6 +165,7 @@ func TestHelmArgCleaner(t *testing.T) {
 		`bar`:        `bar`,
 		`not, clean`: `not\, clean`,
 		`a\,b,c`:     `a\,b\,c`,
+		`{a,b,c}`:    `{a,b,c}`,
 	} {
 		cleaned := cleanSetParameters(input)
 		assert.Equal(t, expected, cleaned)