Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no single quotes around resource names in delete prompts (#10008) #10305

Closed
wants to merge 2 commits into from

Conversation

crenshaw-dev
Copy link
Collaborator

Fixes #10008

Signed-off-by: CI <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #10305 (a84a43e) into master (b38ff17) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10305   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         228      228           
  Lines       27960    27960           
=======================================
  Hits        12900    12900           
  Misses      13314    13314           
  Partials     1746     1746           
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crenshaw-dev
Copy link
Collaborator Author

Closing because it needs styles, and .code-inline looks bad. Will leave for a UI expert to pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove quotes from delete dialog
1 participant