Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagation policy radio buttons/labels don't use cursor: pointer #10864

Closed
crenshaw-dev opened this issue Oct 8, 2022 · 2 comments · Fixed by #10867
Closed

Propagation policy radio buttons/labels don't use cursor: pointer #10864

crenshaw-dev opened this issue Oct 8, 2022 · 2 comments · Fixed by #10867
Assignees
@Sakshi-75
Labels
accessibility For improving the accessibility of UI bug Something isn't working cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 component:ui User interfaces bugs and enhancements good first issue Good for newcomers hacktoberfest

Comments

@crenshaw-dev
Copy link
Collaborator

Describe the bug

Hovering the propagation policy checkboxes/labels does not use the cursor: pointer as do other radio buttons/labels in the UI.

To Reproduce

  1. Click the "delete" button on an Application.
  2. Hover the propagation policy radio buttons/labels
  3. Note that the cursor does not change to a pointer

Expected behavior

The cursor should change to a pointer on hover.

Screenshots

Screen.Recording.2022-10-08.at.4.33.59.PM.mov

Version

2.5.0-rc1
@crenshaw-dev crenshaw-dev added bug Something isn't working good first issue Good for newcomers component:ui User interfaces bugs and enhancements hacktoberfest accessibility For improving the accessibility of UI cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Oct 8, 2022
@Sakshi-75
Copy link
Contributor

Hi @crenshaw-dev ,
I would like to work on this. Can you assign it to me please?

@Sakshi-75 Sakshi-75 mentioned this issue Oct 8, 2022
Merged
10 tasks
@Sakshi-75
Copy link
Contributor

Hi @crenshaw-dev ,
I've raised a PR for this: #10867
Please review it.

crenshaw-dev pushed a commit that referenced this issue Oct 9, 2022
@Sakshi-75
fix: added css to change cursor to pointer on hover (#10864) (#10867)
51d34dd 
* added css to change cursor to pointer on hover

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

* moved cursor change to only label and input

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 9, 2022
@Sakshi-75 @crenshaw-dev
fix: added css to change cursor to pointer on hover (#10864) (#10867)
0b076c1 
* added css to change cursor to pointer on hover

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

* moved cursor change to only label and input

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 9, 2022
@Sakshi-75 @crenshaw-dev
fix: added css to change cursor to pointer on hover (#10864) (#10867)
983a7b0 
* added css to change cursor to pointer on hover

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

* moved cursor change to only label and input

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 9, 2022
@Sakshi-75 @crenshaw-dev
fix: added css to change cursor to pointer on hover (#10864) (#10867)
2465c92 
* added css to change cursor to pointer on hover

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

* moved cursor change to only label and input

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev pushed a commit that referenced this issue Oct 9, 2022
@Sakshi-75 @crenshaw-dev
fix: added css to change cursor to pointer on hover (#10864) (#10867)
2100fe8 
* added css to change cursor to pointer on hover

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

* moved cursor change to only label and input

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>

Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sakshi-75 Sakshi-75

Labels
accessibility For improving the accessibility of UI bug Something isn't working cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 component:ui User interfaces bugs and enhancements good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added css to change cursor to pointer on hover (#10864) Sakshi-75/argo-cd
2 participants
@crenshaw-dev @Sakshi-75