fix: added css to change cursor to pointer on hover (#10864) #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakshi-75
force-pushed
the
change-cursor-on-hover
branch
from
22af768
to
c558cd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10867 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 236 236
Lines 28698 28698
=======================================
Hits 13110 13110
Misses 13796 13796
Partials 1792 1792 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Oct 9, 2022
Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
Sakshi-75
force-pushed
the
change-cursor-on-hover
branch
from
e1c9270
to
c3a83a3
Compare
crenshaw-dev
changed the title
crenshaw-dev
approved these changes
Oct 9, 2022
There was a problem hiding this comment.
Reproduce the issue in 2.2.14, 2.3.9, 2.4.15, and 2.5.0-rc1 and then tested the fix. LGTM, thanks @Sakshi-75!
crenshaw-dev
added
cherry-pick/2.2
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 9, 2022
* added css to change cursor to pointer on hover Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> * moved cursor change to only label and input Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 9, 2022
* added css to change cursor to pointer on hover Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> * moved cursor change to only label and input Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 9, 2022
* added css to change cursor to pointer on hover Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> * moved cursor change to only label and input Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 9, 2022
* added css to change cursor to pointer on hover Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> * moved cursor change to only label and input Signed-off-by: Sakshi <sakshi.jain7597@gmail.com> Signed-off-by: Sakshi <sakshi.jain7597@gmail.com>
|
Cherry-picked onto release-2.2 for 2.2.15, release-2.3 for 2.3.10, release-2.4 for 2.4.15, and release-2.5 for 2.5.0-rc2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Fixes Propagation policy radio buttons/labels don't use
cursor: pointer#10864