-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.6 RC1 - sidecar plugin - spec.parameters.dynamic.command do not have in env ARGOCD_ENV_* variables #11812
Labels
Comments
crenshaw-dev
added
component:cmp
Config Management Plugin related issues
cherry-pick/2.6
labels
Dec 22, 2022
crenshaw-dev
added a commit
to crenshaw-dev/argo-cd
that referenced
this issue
Dec 22, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this issue
Mar 22, 2023
* fix: pass env when getting param announcement (#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Mar 22, 2023
* fix: pass env when getting param announcement (#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this issue
Mar 23, 2023
* fix: pass env when getting param announcement (#11812) * use same method as other methods * better tests * make sure env var tests are meaningful --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this issue
Aug 9, 2023
…roj#11815) * fix: pass env when getting param announcement (argoproj#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sidecar plugin - spec.parameters.dynamic.command do not have in env ARGOCD_ENV_* variables
generate.command is working as expected
kind: ConfigManagementPlugin
miracle-plugin-param.sh
miracle-plugin.sh
generate.command is working as expected
The text was updated successfully, but these errors were encountered: