fix: pass env when getting param announcement (#11812) #11815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
leoluz
requested changes
Mar 1, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick 2.6 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #11815 +/- ##
=======================================
Coverage 47.79% 47.80%
=======================================
Files 246 246
Lines 41968 41969 +1
=======================================
+ Hits 20058 20062 +4
+ Misses 19910 19908 -2
+ Partials 2000 1999 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
* fix: pass env when getting param announcement (#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Mar 23, 2023
* fix: pass env when getting param announcement (#11812) * use same method as other methods * better tests * make sure env var tests are meaningful --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…roj#11815) * fix: pass env when getting param announcement (argoproj#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11812