Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD custom healthcheck issue #12715

Open
3 tasks done
jakubtomiak97 opened this issue Mar 3, 2023 · 2 comments
Open
3 tasks done

ArgoCD custom healthcheck issue #12715

jakubtomiak97 opened this issue Mar 3, 2023 · 2 comments
Assignees
@reggie-k
Labels
bug Something isn't working

Comments

@jakubtomiak97
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Hello!

Seems like there is a bug with custom healthchecks when using wildcard at the beginning.

example which does not work

resource.customizations: |
    *.aws.crossplane.io/*:
      health.lua: | 
        ...

this works fine

resource.customizations: |
    smth.aws.crossplane.io/*:
      health.lua: | 
        ...

Documentation link with above example.

To Reproduce

Add above custom healthcheck to the argocd configmap.

Expected behavior

Healthcheck works fine for option number 1.

Version

2.6.3
@jakubtomiak97 jakubtomiak97 added the bug Something isn't working label Mar 3, 2023
@reggie-k reggie-k self-assigned this Mar 3, 2023
@reggie-k
Copy link
Member

reggie-k commented Mar 6, 2023 •
edited

@jakubtomiak97
Seems like a misdocumentation.
Can you please confirm that it works for you when surrounded by quotes?
"*.aws.crossplane.io/*"

@jakubtomiak97
Copy link
Author

@reggie-k yup, that one works. Thanks!

crenshaw-dev added a commit that referenced this issue Mar 6, 2023
@reggie-k @crenshaw-dev
chore: Add unit tests for the shared health resource feature and fix …
f9e6526 
…docs (#12715) (#12720)

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* will the tests fail?

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* lua tests with relative path

Signed-off-by: reggie <reginakagan@gmail.com>

* bye bye custom action

Signed-off-by: reggie <reginakagan@gmail.com>

* placatin custom actions tests

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>

---------

Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Mar 6, 2023
@reggie-k @crenshaw-dev
chore: Add unit tests for the shared health resource feature and fix …
3a368b9 
…docs (#12715) (#12720)

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* will the tests fail?

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* lua tests with relative path

Signed-off-by: reggie <reginakagan@gmail.com>

* bye bye custom action

Signed-off-by: reggie <reginakagan@gmail.com>

* placatin custom actions tests

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>

---------

Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Mar 6, 2023
Merged
crenshaw-dev added a commit that referenced this issue Mar 6, 2023
@gcp-cherry-pick-bot @reggie-k @crenshaw-dev
chore: Add unit tests for the shared health resource feature and fix …
fca7f58 
…docs (#12715) (#12720) (#12731)

* Dummy action in



* Dummy action in



* happy happy joy joy



* will the tests fail?



* happy happy joy joy



* lua tests with relative path



* bye bye custom action



* placatin custom actions tests



* added tests and fixed docs



* added tests and fixed docs



* Update docs/operator-manual/health.md




---------

Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>
Co-authored-by: reggie-k <reginakagan@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@reggie-k @crenshaw-dev
chore: Add unit tests for the shared health resource feature and fix …
255f017 
…docs (argoproj#12715) (argoproj#12720)

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* Dummy action in

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* will the tests fail?

Signed-off-by: reggie <reginakagan@gmail.com>

* happy happy joy joy

Signed-off-by: reggie <reginakagan@gmail.com>

* lua tests with relative path

Signed-off-by: reggie <reginakagan@gmail.com>

* bye bye custom action

Signed-off-by: reggie <reginakagan@gmail.com>

* placatin custom actions tests

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* added tests and fixed docs

Signed-off-by: reggie <reginakagan@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>

---------

Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie-k <reginakagan@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reggie-k reggie-k

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reggie-k @jakubtomiak97