chore: Add unit tests for the shared health resource feature and fix docs (#12715) #12720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
reggie-k
changed the title
reggie-k
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12720 +/- ##
=======================================
Coverage 47.79% 47.80%
=======================================
Files 246 246
Lines 41952 41951 -1
=======================================
+ Hits 20051 20054 +3
+ Misses 19900 19897 -3
+ Partials 2001 2000 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
reviewed
Mar 6, 2023
crenshaw-dev
changed the title
|
/cherry-pick release-2.6 |
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: reggie-k <reginakagan@gmail.com>
crenshaw-dev
approved these changes
Mar 6, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
…docs (#12715) (#12720) * Dummy action in Signed-off-by: reggie <reginakagan@gmail.com> * Dummy action in Signed-off-by: reggie <reginakagan@gmail.com> * happy happy joy joy Signed-off-by: reggie <reginakagan@gmail.com> * will the tests fail? Signed-off-by: reggie <reginakagan@gmail.com> * happy happy joy joy Signed-off-by: reggie <reginakagan@gmail.com> * lua tests with relative path Signed-off-by: reggie <reginakagan@gmail.com> * bye bye custom action Signed-off-by: reggie <reginakagan@gmail.com> * placatin custom actions tests Signed-off-by: reggie <reginakagan@gmail.com> * added tests and fixed docs Signed-off-by: reggie <reginakagan@gmail.com> * added tests and fixed docs Signed-off-by: reggie <reginakagan@gmail.com> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: reggie-k <reginakagan@gmail.com> --------- Signed-off-by: reggie <reginakagan@gmail.com> Signed-off-by: reggie-k <reginakagan@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Mar 6, 2023
…docs (#12715) (#12720) (#12731) * Dummy action in * Dummy action in * happy happy joy joy * will the tests fail? * happy happy joy joy * lua tests with relative path * bye bye custom action * placatin custom actions tests * added tests and fixed docs * added tests and fixed docs * Update docs/operator-manual/health.md --------- Signed-off-by: reggie <reginakagan@gmail.com> Signed-off-by: reggie-k <reginakagan@gmail.com> Co-authored-by: reggie-k <reginakagan@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…docs (argoproj#12715) (argoproj#12720) * Dummy action in Signed-off-by: reggie <reginakagan@gmail.com> * Dummy action in Signed-off-by: reggie <reginakagan@gmail.com> * happy happy joy joy Signed-off-by: reggie <reginakagan@gmail.com> * will the tests fail? Signed-off-by: reggie <reginakagan@gmail.com> * happy happy joy joy Signed-off-by: reggie <reginakagan@gmail.com> * lua tests with relative path Signed-off-by: reggie <reginakagan@gmail.com> * bye bye custom action Signed-off-by: reggie <reginakagan@gmail.com> * placatin custom actions tests Signed-off-by: reggie <reginakagan@gmail.com> * added tests and fixed docs Signed-off-by: reggie <reginakagan@gmail.com> * added tests and fixed docs Signed-off-by: reggie <reginakagan@gmail.com> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: reggie-k <reginakagan@gmail.com> --------- Signed-off-by: reggie <reginakagan@gmail.com> Signed-off-by: reggie-k <reginakagan@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: