Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate chat button url only when chatUrl is set #12749

Conversation

rouke-broersma
Copy link
Contributor

@rouke-broersma rouke-broersma commented Mar 7, 2023

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Fixes #12655

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
@rouke-broersma rouke-broersma changed the title Validate chat button url only when chatUrl is set fix: Validate chat button url only when chatUrl is set Mar 7, 2023
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f500a5) 47.79% compared to head (22187f7) 47.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12749   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         246      246           
  Lines       41968    41968           
=======================================
  Hits        20058    20058           
  Misses      19910    19910           
  Partials     2000     2000           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.4

@crenshaw-dev crenshaw-dev merged commit 6953b43 into argoproj:master Mar 7, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 7, 2023
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 7, 2023
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 7, 2023
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 7, 2023
…) (#12757)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 7, 2023
…) (#12758)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 7, 2023
…) (#12759)

* Validate chat button url only when chatUrl is set



* Add Info Support to argocd USERS.md



* Fix linter error



* Fix linter error



---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
@rouke-broersma rouke-broersma deleted the 12655-fix-chat-button-when-url-empty branch May 3, 2023 09:33
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
… (argoproj#12749)

* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not configured chat url results in chat button shown
2 participants