New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Validate chat button url only when chatUrl is set #12749
Merged
crenshaw-dev
merged 4 commits into
argoproj:master
from
rouke-broersma:12655-fix-chat-button-when-url-empty
Mar 7, 2023
Merged
fix: Validate chat button url only when chatUrl is set #12749
crenshaw-dev
merged 4 commits into
argoproj:master
from
rouke-broersma:12655-fix-chat-button-when-url-empty
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
rouke-broersma
changed the title
Validate chat button url only when chatUrl is set
fix: Validate chat button url only when chatUrl is set
Mar 7, 2023
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12749 +/- ##
=======================================
Coverage 47.79% 47.79%
=======================================
Files 246 246
Lines 41968 41968
=======================================
Hits 20058 20058
Misses 19910 19910
Partials 2000 2000 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
approved these changes
Mar 7, 2023
/cherry-pick release-2.6 |
/cherry-pick release-2.5 |
/cherry-pick release-2.4 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Validate chat button url only when chatUrl is set Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Add Info Support to argocd USERS.md Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Validate chat button url only when chatUrl is set Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Add Info Support to argocd USERS.md Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Validate chat button url only when chatUrl is set Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Add Info Support to argocd USERS.md Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Mar 7, 2023
…) (#12757) * Validate chat button url only when chatUrl is set * Add Info Support to argocd USERS.md * Fix linter error * Fix linter error --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Mar 7, 2023
…) (#12758) * Validate chat button url only when chatUrl is set * Add Info Support to argocd USERS.md * Fix linter error * Fix linter error --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Mar 7, 2023
…) (#12759) * Validate chat button url only when chatUrl is set * Add Info Support to argocd USERS.md * Fix linter error * Fix linter error --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> Co-authored-by: Rouke Broersma <rouke.broersma@infosupport.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
… (argoproj#12749) * Validate chat button url only when chatUrl is set Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Add Info Support to argocd USERS.md Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> * Fix linter error Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com> --------- Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Fixes #12655