fix: pass env when getting param announcement (#11812) (cherry-pick #11815) #12966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix: pass env when getting param announcement (#11812) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use same method as other methods Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make sure env var tests are meaningful Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.6 #12966 +/- ##
============================================
Coverage 47.65% 47.66%
============================================
Files 246 246
Lines 41749 41750 +1
============================================
+ Hits 19897 19901 +4
+ Misses 19865 19863 -2
+ Partials 1987 1986 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Mar 22, 2023
crenshaw-dev
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: pass env when getting param announcement (#11812) (#11815)
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com