-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new Inputs/Sources tab to replace Parameters tab so that all sources from a multi-source app are displayed #17274
Labels
Comments
keithchong
added a commit
to keithchong/argo-cd
that referenced
this issue
Feb 22, 2024
…proj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com>
14 tasks
keithchong
added a commit
to keithchong/argo-cd
that referenced
this issue
Feb 22, 2024
…proj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
added a commit
to keithchong/argo-cd
that referenced
this issue
Mar 1, 2024
…proj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com>
ishitasequeira
pushed a commit
that referenced
this issue
Apr 16, 2024
…) (#17275) * feat: Add Sources tab to show all sources of a multi-source app (#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this issue
Jun 11, 2024
…proj#17274) (argoproj#17275) * feat: Add Sources tab to show all sources of a multi-source app (argoproj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this issue
Jun 16, 2024
…proj#17274) (argoproj#17275) * feat: Add Sources tab to show all sources of a multi-source app (argoproj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
keithchong
added a commit
to keithchong/argo-cd
that referenced
this issue
Aug 21, 2024
Signed-off-by: Keith Chong <kykchong@redhat.com>
ishitasequeira
pushed a commit
that referenced
this issue
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
This is to cover the first part of the implementation details in the proposal: #17108.
Specifically, this will cover part #1 from here:
https://github.com/argoproj/argo-cd/blob/a0f800cdcc30ef36548cfdcccda0352080f77269/docs/proposals/multiple-sources-for-applications-ui.md#implementation-details
Currently, the UI only shows the first source of the multi-source app. With this change, all sources will be displayed in the new Inputs/Sources tab. The change should support the source field and the new sources field. The current behaviour will remain the same for single source apps using the source field.
Proposal
See #17108
The text was updated successfully, but these errors were encountered: