Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application controller needs a liveness probe #1782

Closed
jessesuen opened this issue Jun 19, 2019 · 0 comments · Fixed by #1785
Closed

application controller needs a liveness probe #1782

jessesuen opened this issue Jun 19, 2019 · 0 comments · Fixed by #1785
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jessesuen
Copy link
Member

We hit a situation where application controller could not talk to the K8s API server (which it was running on), failing with network unreachable. A application controller pod deletion had fixed the issue.

We currently have a readiness probe which simply gets the kubernetes version which the controller is running on, but we do not use this as a liveness probe. If we used this same check for liveness, then kubernetes would have killed our container, and we might have automatically recovered from the failure to talk to the K8s api server.

I say might because I'm not sure if container restart would have fixed it, or if a pod deletion was necessary to fix the problem.

@jessesuen jessesuen added the bug Something isn't working label Jun 19, 2019
@jessesuen jessesuen added this to the v1.1 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants